Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pip attempts to install pywinpty on Python 2.7 #143

Closed
andy-maier opened this issue Apr 27, 2021 · 1 comment · Fixed by #144
Closed

Pip attempts to install pywinpty on Python 2.7 #143

andy-maier opened this issue Apr 27, 2021 · 1 comment · Fixed by #144
Assignees
@andfoy
Milestone
v1.0.1

Comments

@andy-maier
Copy link

andy-maier commented Apr 27, 2021 •
edited
Loading

Pywinpty does not declare which Python versions it supports. This causes pip to install the latest version 1.0.0 on Python 2.7 (which fails when installing the 'maturin' dependent package).

The proper fix for this is to declare the supported Python versions in the pywinpty package such that pip recognizes them.
@andy-maier andy-maier changed the title pywinpty no longer installs on Python 2.7 Pip attempts to install pywinpty on Python 2.7 Apr 27, 2021
@andy-maier andy-maier mentioned this issue Apr 27, 2021
Closed
@ccordoba12 ccordoba12 added this to the v1.0.1 milestone Apr 27, 2021
@ccordoba12
Copy link
Contributor

ccordoba12 commented Apr 27, 2021 •
edited
Loading

Hey @andy-maier, thanks for reporting. You're totally right.

@andfoy, I think we need to add python_requires to our pyproject.toml to fix this.

@andfoy andfoy mentioned this issue Apr 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andfoy andfoy

Labels
None yet
Projects
None yet
Milestone
v1.0.1
Development

Successfully merging a pull request may close this issue.

PR: Add requires-python key in pyproject.toml
3 participants
@ccordoba12 @andfoy @andy-maier