Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance chroma keying #146

Closed
sualko opened this issue Oct 18, 2019 · 2 comments
Closed

Enhance chroma keying #146

sualko opened this issue Oct 18, 2019 · 2 comments
Labels
enhancement

Comments

@sualko
Copy link
Collaborator

sualko commented Oct 18, 2019 •
edited
Loading

I did some tests with an example image which I found in the internet and I think the result is very disappointing. A quick test with seriously.js looked much better. The library was not updated in the last years, but the current library is also not that active 😉. I think we could switch libraries, if we look at #126. One think we should test before, if seriously.js is also running on a raspberry, because I think it is using webgl.

Original image:
2019-10-18 21 11 09 796798eee342

Current implementation:
2019-10-18 21 10 48 localhost ca927eeb8e22

Seriously.js:
2019-10-18 21 10 35 4baa330ca932

<!DOCTYPE html>
<html>
<head><title>Seriously.js Tutorial</title></head>
<body>
        <img src="chroma.png" id="test" />
        
        <canvas id="canvas" width="1600" height="900" style="background-color: yellow"></canvas>

	<script src="seriously.js"></script>
	<script src="effects/seriously.chroma.js"></script>
	
	<script>        
        (function() {
		let seriously = new Seriously();
		let image = seriously.source('#test');
		let target = seriously.target('#canvas');
		let chroma = seriously.effect('chroma');

		chroma.source = image;
		target.source = chroma;
		seriously.go();
	}());
	</script>
</body>
</html>
@andi34
Copy link
Collaborator

andi34 commented Oct 19, 2019

Wow, that's a big difference.

@andi34 andi34 mentioned this issue Oct 28, 2020
Merged
2 tasks
@andi34
Copy link
Collaborator

andi34 commented Oct 4, 2022

Available since Photobooth v3
https://photoboothproject.github.io/Changelog

@andi34 andi34 closed this as completed Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sualko @andi34