Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JetSnack] DarkTheme/LightTheme has bug for adapting different rom #706

Open
zhanglianyu0911 opened this issue Nov 26, 2021 · 11 comments
Open
Assignees

Comments

@zhanglianyu0911
Copy link

I found all of my XIAOMI series phones has displayed issue when I set my phone as dark mode (see following attachment, I am using Jetsnack as sample)

image

I am trying to show light mode when enable system dark mode by using darkTheme = false like below, but the app still show dark mode color.

image

Even though when I start a simple new project and force set show light mode when system dark mode enabled, same issue appears.

However when I run on Pixel emulator, everything works fine, so I suppose it should be a rom adapting issue, any chance can report this issue for Compose Library team? I have not try HUAWEI, OPPO, VIVO, ONE PLUS, it may contains other potential rom adapt issue

@JoKar4285
Copy link

I have the same issue. It seems it's Xiaomi specific - tried numerous other devices and only Xiaomi so far has this issue.
We have even tried: AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO)
This has no effect either to try disable dark mode. - Our app is dark mode themed anyway so it would be the same in night/day mode. Even setting theme Darkmode = false doesn't work.

@nickbutcher
Copy link
Contributor

I believe this is an issue with force dark being set on some devices. Compose recently disabled force dark as it's not currently compatible. This should be fixed in the next compose update.

@riggaroo riggaroo changed the title DarkTheme/LightTheme has bug for adapting different rom [JetSnack] DarkTheme/LightTheme has bug for adapting different rom May 6, 2022
@ThatsMeJavad
Copy link

any update on this bug? @nickbutcher

@florina-muntenescu
Copy link
Contributor

Issue is currently fixed

@b0r1ngx
Copy link

b0r1ngx commented May 10, 2023

Eh, issue doesn't seems fixed, my users get on Xiaomi in dark mode, and my app only support light theme, some texts - shows bad experience turning from black to white

@EdwardBock
Copy link

Sorry, but I still have color issues with Xiaomi devices and compose version 1.4.3

@kirillkostrov
Copy link

Still not fixed

@b0r1ngx
Copy link

b0r1ngx commented Jul 13, 2023

@florina-muntenescu Hello, developers get an bad expirience!

@Dhanush-Ma
Copy link

Still not fixed. Seems to be a bigger issue.

@riggaroo
Copy link
Collaborator

Hi, @Dhanush-Ma. Can you provide more information as to which version of Compose you are experiencing this on and which Xiaomi version/ device you are running on?

@Dhanush-Ma
Copy link

My team is using
Jetpack Compose version:
[versions]
activityCompose = "1.9.2"
composeBom = "2024.04.01"
navigationCompose = "2.8.3"
composeNavigation = "2.8.0-alpha08"

Android Version: 11
Specific devices: Redmi note 8 Pro
MIUI Version: MIUI Global 12.5.10

Instead of checking on these version try to resolve its all on Xiaomi devices where dark mode switch enable/disable is present outside app level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants