-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M1 yasm #1549
Comments
Rather than upgrade yasm with a universal macOS build, it may make more sense for the NDK to switch to shipping nasm instead. |
We're still blocked on this, and r23c is being prepped right now, so this won't make r23c. Retriaged. |
Hey @DanAlbert, is this something that's still in the works? I don't personally need it, but I figured I'd check since it's the last item for M1 support: #1299 |
Depends on what you mean by "in the works". We are not actively working on all 143 of our open bugs because we don't have that kind of bandwidth. This is still on the todo list, but is low priority because we don't actually know if anyone needs this. |
Users/fpliu/.ndk-pkg/uppm/installed/android-ndk-r26d/toolchains/llvm/prebuilt/darwin-x86_64/bin/yasm: Bad CPU type in executable Is yasm necessary to be shipped with Android NDK? |
For the people that use it, yes. We can't have metrics without making yasm phone home, which I'm not going to do, so we can't know how many people use it. It costs us nothing to keep around, so we don't plan to remove it. |
Kicking this to the backlog. We've heard no complaints about it in the years since the rest of the NDK got M1 support, so I suspect no one actually uses this. If that's wrong, please speak up. The "fix" here is not trivial because it likely means replacing yasm with nasm. As long as we think no one is using it, that work's just not going to make it to the top of the triage list. We don't have any plans to actually remove it though. Status quo has cost nothing in maintenance for the past few years, so I'd rather avoid breaking anyone happily using it without native M1 support :) |
Subtask for #1299
The text was updated successfully, but these errors were encountered: