Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: ANDROID_ARM_NEON #813

Closed
Zingam opened this issue Oct 10, 2018 · 5 comments
Closed

Docs: ANDROID_ARM_NEON #813

Zingam opened this issue Oct 10, 2018 · 5 comments
Assignees
Labels

Comments

@Zingam
Copy link

Zingam commented Oct 10, 2018

The change log states that "ndk-build and CMake now default to using NEON for ARM when targeting android-23 (Marshmallow) or newer."
https://github.com/android-ndk/ndk/wiki/Changelog-r18
The docs here state
ANDROID_ARM_NEON FALSE (default)
Shouldn't that discrepancy be clarified?

@enh
Copy link
Contributor

enh commented Oct 11, 2018

you might have to hit reload, but this should be fixed now.

(at some point we need to find the time to go through all of these and check that they're still accurate, but in the meantime please file bugs for any more mistakes you find.)

@enh enh closed this as completed Oct 11, 2018
@Zingam
Copy link
Author

Zingam commented Oct 12, 2018

@enh How does one make sure that NEON builds are enabled? None of these seem to be set in my CMakeLists.txt

${CMAKE_ANDROID_ARM_NEON}
${ANDROID_ARM_NEON}

@DanAlbert
Copy link
Member

Look at the build log. Look for -mfpu=neon

@Zingam
Copy link
Author

Zingam commented Oct 13, 2018

My mistake. I use an external CMake #463 and if I get it right it won't matter in the future because it will be enabled in the driver #812
Thanx!

@DanAlbert
Copy link
Member

Correct. If you're not using our toolchain file none of this will be handled for you. Enabling NEON by default for Clang regardless of build system won't happen until r20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants