You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
Hi everyone,
I'm found a little confuse in current app's ViewModels as there used an viewModelScope from ktx in which implementation coroutine context gets cancel on it's close. But in app's ViewModels onCleared method overriden and there viewModelScope.cancel() call could be found.
It looks like onCleared override could be cleaned up from ViewModels as viewModelScope's context cancelation handled by the lib.
Hi everyone,
I'm found a little confuse in current app's ViewModels as there used an viewModelScope from ktx in which implementation coroutine context gets cancel on it's close. But in app's ViewModels onCleared method overriden and there
viewModelScope.cancel()
call could be found.It looks like onCleared override could be cleaned up from ViewModels as viewModelScope's context cancelation handled by the lib.
references that could be useful:
ktx-viewModelScope source,
ViewModel source
The text was updated successfully, but these errors were encountered: