Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JetStream] Migrate the bringIntoViewIfChildrenAreFocused modifier from composed function to Modifier.Node #171

Open
chikoski opened this issue May 20, 2024 · 0 comments
Open

[JetStream] Migrate the bringIntoViewIfChildrenAreFocused modifier from composed function to Modifier.Node #171

chikoski opened this issue May 20, 2024 · 0 comments

Comments

@chikoski
Copy link
Contributor

  • The bringIntoViewIfChildrenAreFocused modifier uses composed function.
  • The composed function causes the whole modifier chain to be re-composed every time.
  • The bringIntoViewIfChildrenAreFocused modifier should switch its implementation to Modifer.Node for better performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chikoski