Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't get it to work #4

Closed
flobiwankenobi opened this issue Oct 27, 2017 · 9 comments
Closed

Can't get it to work #4

flobiwankenobi opened this issue Oct 27, 2017 · 9 comments

Comments

@flobiwankenobi
Copy link

Hey, I'm using Windows 10 1709 and VS Code 1.17.2.

I renamed wslgit.exe into git.exe and added it to the PATH variable.

VSCode settings
"git.enabled": true, "git.path": "C:\\Users\\<username>\\AppData\\Local\\Git\\git.exe",
I can use git with PowerShell, CMD and of course Bash for Ubuntu, but not in VS Code.

@andy-5
Copy link
Owner

andy-5 commented Oct 29, 2017

Are you using an old WSL Beta environment (Bash on Windows) or did you install the Linux Distribution from the Store (which is the new way since the Fall Creators Update)?

If C:\Users\<username>\AppData\Local\Git\git.exe --version works in PowerShell or in CMD, then you probably have an old style environment, because wslgit currently does not support the new WSL Linux environments.

What exactly does not work in VS Code? Any errors? Does it detect the repository if you open a version controlled directory?

Could you post the output of the Git console in VS Code?

@flobiwankenobi
Copy link
Author

I think it's the old Beta, because it's called "Bash on Ubuntu on Windows". I'll try it with the Ubuntu Distribution from the Microsoft store.

VS Code just doesn't recognize that the project has git.

@andy-5
Copy link
Owner

andy-5 commented Nov 4, 2017

Ok. However, it won't work with the new version from the store, as they use different executables to call into the WSL environment. I haven't implemented support for them, currently.

Can you post the output of the git console from VS Code? It should contain the git commands VS Code tries to run to detect the git repository, etc.
You can then run the same commands in a CMD shell to check their outputs.

@andy-5
Copy link
Owner

andy-5 commented Nov 7, 2017

I just reproduced this problem on Windows 10 1709 with VS Code 1.17.2.
Unfortunately, there is also no git log output from VS Code on why it is failing.

I'll take a closer look on what is going on.

@flobiwankenobi
Copy link
Author

Cool.

@andy-5
Copy link
Owner

andy-5 commented Nov 8, 2017

I just released a new version that should hopefully fix this. Please try the latest release here:

https://github.com/andy-5/wslgit/releases/tag/v0.3.0

@andy-5 andy-5 closed this as completed Nov 8, 2017
@flobiwankenobi
Copy link
Author

I'll try it this evening and give you some feedback.

@flobiwankenobi
Copy link
Author

JFYI: Your fix is working.

@andy-5
Copy link
Owner

andy-5 commented Nov 9, 2017

Great, thanks for reporting back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants