From eb85366482990c0923746fd1d748360a0ee72109 Mon Sep 17 00:00:00 2001 From: andy Date: Wed, 13 Nov 2019 11:18:46 +0800 Subject: [PATCH] planner: fix the output and improve the test coverage #525 [summary] fix the output and improve the test coverage [test case] src/planner/builder/builder_test.go [patch codecov] src/planner/builder/project.go 98.1% --- src/planner/builder/builder_test.go | 4 ++++ src/planner/builder/project.go | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/planner/builder/builder_test.go b/src/planner/builder/builder_test.go index deadc108..1b6f0f3c 100644 --- a/src/planner/builder/builder_test.go +++ b/src/planner/builder/builder_test.go @@ -508,6 +508,8 @@ func TestSelectUnsupported(t *testing.T) { "select a+1 from A group by a+1", "select count(distinct *) from A", "select t1.a from G", + "select S.id from A join B on B.id=A.id", + "select eeeee from A join B on B.id=A.id", } results := []string{ "unsupported: subqueries.in.select", @@ -547,6 +549,8 @@ func TestSelectUnsupported(t *testing.T) { "unsupported: group.by.[a + 1].type.should.be.colname", "unsupported: syntax.error.at.'count(distinct *)'", "unsupported: unknown.column.'t1.a'.in.exprs", + "unsupported: unknown.column.'S.id'.in.field.list", + "unsupported: unknown.column.'eeeee'.in.select.exprs", } log := xlog.NewStdLog(xlog.Level(xlog.PANIC)) diff --git a/src/planner/builder/project.go b/src/planner/builder/project.go index 5b76746a..f2ae2705 100644 --- a/src/planner/builder/project.go +++ b/src/planner/builder/project.go @@ -72,7 +72,7 @@ func parseSelectExpr(expr *sqlparser.AliasedExpr, tbInfos map[string]*tableInfo) } } else { if _, ok := tbInfos[tableName]; !ok { - return false, errors.Errorf("unsupported: unknown.column.'%s'.in.field.list", field) + return false, errors.Errorf("unsupported: unknown.column.'%s.%s'.in.field.list", tableName, field) } }