Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write more tests by consuming tsserver #16

Open
angelozerr opened this issue Apr 20, 2017 · 5 comments
Open

Write more tests by consuming tsserver #16

angelozerr opened this issue Apr 20, 2017 · 5 comments

Comments

@angelozerr
Copy link
Owner

We must really write more tests by consuming tsserver. No idea for the moment how to do that. TypeScript project contains a lot of tests which consumes tsserver API, perhaps we could do the same thing?

@Istar-Eldritch
Copy link
Contributor

I'll try to take a look into this next week if no one runs faster ;)

@angelozerr
Copy link
Owner Author

@Istar-Eldritch if you have time to do that, it should really cool. Thanks!

After that we will able to add tests for each features that we will add.

@angelozerr
Copy link
Owner Author

@Istar-Eldritch is there any chance that you could work on this issue?

@Istar-Eldritch
Copy link
Contributor

I'll start researching this tomorrow. I'm taking a look now at the tsserver protocol. My plan is:

  • Modularize the code in small functions and unit test them.
  • Write a few integration tests to ensure that the version of tsserver used does not break the plugin. This is, warn us if the plugin does not work in a new version of tsserver.

I'll probably ask some questions before I spend the time writing code, mainly because I feel I'll have to do some refactoring to isolate and make the code testable. I may also create a work in progress PR so we can discuss directly on it.

@angelozerr
Copy link
Owner Author

Great news.

So I will have time to study and try to implement #2 and #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants