Tiny typing fix #406
Merged
Tiny typing fix #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Regions class is implicitly iterable because it defines __len__ and __getitem__. Mypy doesn't like this, and the recommendation seems to be to just make __iter__ explicit: https://stackoverflow.com/a/61739436/13220684
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Regions class is implicitly iterable because it defines
__len__and__getitem__.Mypy doesn't like this, and the recommendation seems to be to just make
__iter__explicit: https://stackoverflow.com/a/61739436/13220684