Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lifter.lift and _lift are backwards #343

Closed
twizmwazin opened this issue Aug 30, 2023 · 0 comments · Fixed by #344
Closed

Lifter.lift and _lift are backwards #343

twizmwazin opened this issue Aug 30, 2023 · 0 comments · Fixed by #344
Labels
enhancement needs-triage

Comments

@twizmwazin
Copy link
Member

twizmwazin commented Aug 30, 2023 •
edited
Loading

Description

Starting a function with an underscore indicates that it is a private or protected method not intended for public use. Lifter violates this. lift should be the public method, and _lift should be what subclasses override to provide an implementation.

Alternatives

Let's switch these two around so that normal semantics are respected.

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Swap Lifter.lift and Lifter._lift to respect public/private semantics angr/pyvex
1 participant
@twizmwazin