AngularJS 1.3 Support?

[tannerlinsley]

There seem to be breaking changes for a couple of 1.3 things. Is ui-router 100% compatible with these changes?

[amcdnl]

Could you be more specific?

[tannerlinsley]

Yeah, when upgrading to 1.3, I get loads of $animate errors. When looking at the breaking changes introduced in 1.3, there are some parameter and default parameter changes. It specifically says to search your code for the old $animate syntax and replace with the new one. When searching through my bower_components, ui-router comes up once or twice.

https://docs.angularjs.org/guide/migration has more details on it, but I was just wondering if this needed to be addressed.

[AimeeKnight]

@amcdnl We're also having problems related to issue #1397. Appears the if block to prepend the url with $locationProvider.hashPrefix() is not getting tripped.

[christopherthielen]

#1397 is fixed in master. @tannerlinsley Can I get a plunkr for $animate errors?

[christopherthielen]

Hmm, we already updated the animation code for 1.3.0. See #1364 #1345 #1367

I switched the sample app over to angular 1.3.0 and other than #1397, 0.2.11 seemed to do fine with 1.3.0.

[AimeeKnight]

@christopherthielen we are having the issue in 0.2.11 as well as 0.2.12 (master). We're using Bower/Require, and it looks like release/angular-ui-router has not been updated with the fix.

[gaarf]

👍 am also hoping for quick release of 0.2.12 to bower

[christopherthielen]

I don't know what the error is. I'll need a plunkr in order to determine the bug and fix it.
@AimeeKnight

[christopherthielen]

@christopherthielen we are having the issue in 0.2.11 as well as 0.2.12 (master). We're using Bower, and it looks like release/angular-ui-router has not been updated with the fix.

Are you saying you tried to use bower to grab master? It doesn't work that way, you have to build master yourself. Check the header of angular-ui-router.js and it will probably say 0.2.11. @AimeeKnight please confirm.

[AimeeKnight]

@christopherthielen Apologies. You're correct.

[musketyr]

👍 for quick release

[janosgy]

+1

[jasonmacdonald]

Also see issues with how state.href works. It' checks for !$locationProvider.html5Mode(), but in 1.3 the location manager is setting that value to an object, seen below

html5Mode = {
enabled: false,
requireBase: true,
rewriteLinks: true
};

This always evaluates to "true" (despite enabled = false) and therefore all calls to state.href are stripping the "#" from generated urls.

Should I create a separate bug for this?

[klategan]

+1 for the change to html5Mode() return type. My Urls are not getting prepended with '#' anymore.

[christopherthielen]

Use 0.2.12-pre1 if you need angular 1.3 html5mode support.

Fixed in 7fea1e9
https://github.com/angular-ui/ui-router/blob/master/src/urlRouter.js#L383

Dupe #1458
Dupe #1413
Dupe #1408
Dupe #1397

[christopherthielen]

It there are still problems using angular 1.3, please open a new issue with explicit details, thanks