Wrong URL generated by UrlMatcherFactory format

[wawyed]

Having 2 states defined as:

var state1 = { name: 'home', url: '/home?param1', controller: function() { }, templateUrl: 'home.html'}
var state2 = { name: 'home.foo', url: '/foo/:id', controller: function() { }, templateUrl: 'foo.html'}

When navigating to state2 (home.foo) with the parameters ({id: "idValue", param1: "param1Value"}) I would expect the URL to look something like:

home/foo/idValue?param1=param1Value.

This is correct and true for 0.2.11, but since 0.2.12 there seems to be a bug with the format of the URL since the generated URL looks like this:

home/foo/param1Value?id=idValue

Which doesn't make any sense since id is not a query string parameter.

Looking at the code the change that seems to be introducing this error is in the function parameters() being called in UrlMatcher.prototype.format at line 989 in 0.2.12 or at line 906 in 0.2.11.

0.2.11 calls the method objectKeys(this.params) which returns the parameters in a different order than 0.2.12 method this.params.$$keys() and that seems to be causing an error in the order the parameters get appended to the generated URL.

Plunkers reproducing the issue:

0.2.11: http://plnkr.co/edit/0L4cLM?p=preview
0.2.12: http://plnkr.co/edit/iVGuKU?p=preview

[christopherthielen]

Thanks, I'll take a look as soon as I have time.

[christopherthielen]

Thanks for the bug report, this is a major bug that I missed. I think the fix for this bug warrants a 0.2.13 release.

[christopherthielen]

http://plnkr.co/edit/emEV8v?p=preview

fixed plunk

[wawyed]

When can we expect 0.2.13? 👍

[christopherthielen]

Should be just a couple days away

[NevilleS]

Just ran into this as well. Thanks for the quick fix!

[kumarharsh]

Man... this was devilishly difficult to find... I was so pissed with my code - why was it breaking all of a sudden when it worked just days ago.... Finally stumbled upon this issue...

Thanks for solving it! Keep up the good work!