Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Make it easier to set withCredentials=true #945

Closed
sdeleuze opened this issue Apr 23, 2014 · 3 comments
Closed

Make it easier to set withCredentials=true #945

sdeleuze opened this issue Apr 23, 2014 · 3 comments

Comments

@sdeleuze
Copy link

Using CORS + setting withCredentials=true in the http request is a quite common need, since it is mandatory for apps with authentication in development mode when your server is running on a port (8080 for example) and AngularDart application on another (3030 for debugging).

withCredentials parameter is available in the deprecated http.request() method, but not on http.post(), http.get() etc. It could be great to allow users to specify a withCredentials named parameter un http.post() and other shortcuts methods.

More details about that in https://groups.google.com/forum/#!topic/angular-dart/8FrOdBoYw-A

@jbdeboer
Copy link
Contributor

jbdeboer commented May 7, 2014

And we've now deleted the deprecated http.request() method, making it even harder to set withCredentials.

@markovuksanovic Could you add withCredentials back to Http?

@mhevery mhevery added this to the 0.11.0 milestone May 7, 2014
@mvuksano
Copy link
Contributor

mvuksano commented May 8, 2014

@jbdeboer Sounds good.

@vicb vicb modified the milestones: 0.12.0, 0.11.0 May 8, 2014
mvuksano added a commit to mvuksano/angular.dart that referenced this issue May 9, 2014
…, etc.) which use credentials (such as cookies or authorization headers).

Closes dart-archive#945
mvuksano added a commit to mvuksano/angular.dart that referenced this issue May 9, 2014
…, etc.) which use credentials (such as cookies or authorization headers).

Closes dart-archive#945
mvuksano added a commit to mvuksano/angular.dart that referenced this issue May 17, 2014
…, etc.) which use credentials (such as cookies or authorization headers).

Closes dart-archive#945
mvuksano added a commit to mvuksano/angular.dart that referenced this issue May 22, 2014
…, etc.) which use credentials (such as cookies or authorization headers).

Closes dart-archive#945
mvuksano added a commit that referenced this issue May 22, 2014
…, etc.) which use credentials (such as cookies or authorization headers).

Closes #945
Closes #1026
@sdeleuze
Copy link
Author

Thanks !

mvuksano added a commit that referenced this issue May 30, 2014
…, etc.) which use credentials (such as cookies or authorization headers).

Closes #945
Closes #1026
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
…, etc.) which use credentials (such as cookies or authorization headers).

Closes dart-archive#945
Closes dart-archive#1026
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
…, etc.) which use credentials (such as cookies or authorization headers).

Closes dart-archive#945
Closes dart-archive#1026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

5 participants