Fixed inconsistency in $location.path() behaviour on the $locationChangeStart event when using back/forward buttons in the browser or manually changing the url in the address bar.

[skoszuta]

This is related to #4989

[mary-poppins]

Thanks for the PR!

• Contributor signed CLA now or in the past
  • If you just signed, leave a comment here with your real name
• PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

[skoszuta]

This is my first pull request. I see the commit message does not exactly follow the rules, so I'll fix it in a moment.

[skoszuta]

Commit message fixed. How do I sign the CLA?

[caitp]

There is a link in CONTRIBUTING.md (https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#signing-the-cla)

Caitlin Potter
[email protected]

On Nov 22, 2013, at 9:00 AM, Sebastian [email protected] wrote:

Commit message fixed. How do I sign the CLA?

—
Reply to this email directly or view it on GitHub.

[skoszuta]

I have signed the CLA. My name is Sebastian Koszuta

[matsko]

@skoszuta please add some test code to this.

[petebacondarwin]

+1 @matsko
@skoszuta - ideally you should have a test that demonstrates the bug you are fixing.

[skoszuta]

Sure. I'll push some tomorrow.

[phelipemaia]

I think locationChangeStart should be executed before everything when you're changing the URL. Am I wrong?

[skoszuta]

Alright. I pushed a test for this. Now, whether the $location should contain the old or new url during $locationChangeStart is something we can discuss. But it's a sure thing that it should be consistent. It would be great if one could access the old and the new url in their parsed forms when $locationChangeStart occurs. "Parsed" as in similar to a raw route, like: /bla. As for now only full URLs are passed to the event listener.

[IgorMinar]

thanks. I improved the test and merged this in.