This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(input): setViewValue on compositionend #5433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is obsolete now, right? |
|
Yeah, I guess close it for now and it can be re-opened if there's another issue related that it solves |
|
Might work to fix #6058, reopening |
Because of a4e6d96, model is not updated on input/change between the compositionstart and compositionend events. Unfortunately, the compositionend event does not always happen prior to an input/change event. This changeset calls the listener function to update the model after a compositionend event is received.
|
LGTM |
1 similar comment
|
LGTM |
khepin
pushed a commit
to khepin/angular.js
that referenced
this pull request
Feb 19, 2014
Because of a4e6d96, model is not updated on input/change between the compositionstart and compositionend events. Unfortunately, the compositionend event does not always happen prior to an input/change event. This changeset calls the listener function to update the model after a compositionend event is received. Closes angular#6058 Closes angular#5433
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of a4e6d96, model is not updated on input/change between the compositionstart and compositionend events. Unfortunately, the compositionend event does not always happen prior to an input/change event.
This changeset calls the listener function to update the model after a compositionend event is received.
This seems to also be an issue on IE10 with certain IMEs
http://plnkr.co/edit/euPnjrLk918G31aTDPjN?p=preview test-case which gives me adequate results on Nexus S
Fixes #5308, #5323