Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(input): don't apply textInput to <input type="file"> #6247

Closed
wants to merge 1 commit into from

Conversation

twhitbeck
Copy link
Contributor

Browser: Chrome Component: misc core Regression: (sort of)

textInput shouldn't be applied to file inputs to ease writing of custom file input directives

Related #6243
Closes #6231

textInput shouldn't be applied to file inputs to ease writing of custom file input directives
@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6247)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@twhitbeck
Copy link
Contributor Author

sorry I couldn't wrangle git in order to recover my other PR. Just created another one instead

@caitp
Copy link
Contributor

caitp commented Feb 13, 2014

It would be cool if we could have a test for this, but I had a go at it the other day and I'm not sure there's any easy way to test this. I'm pretty much okay to just merge it, but I'd like to hear from someone else before-hand.

@twhitbeck
Copy link
Contributor Author

Would the test look something like
<input type="file"> should not be a directive
not exactly sure how to test that...but I'd be happy to write a test for it.

@caitp
Copy link
Contributor

caitp commented Feb 13, 2014

It would be one thing to change the textInputType callback to be a call-through spy, but I feel like this could cause problem for other (or future) specs, so I'd prefer not to do that.

It would be better to test, but in this case I'm not sure it's absolutely necessary.

@caitp
Copy link
Contributor

caitp commented Feb 13, 2014

Alright, so I think we can merge this without a test, for the time being. If we can put one together later on, then we should do that.

@caitp caitp closed this in a9fcb0d Feb 13, 2014
matsko pushed a commit to matsko/angular.js that referenced this pull request Feb 14, 2014
textInput shouldn't be applied to file inputs to ease writing of custom file input directives.

This change prevents file inputs from instantiating the text input parser/formatter pipelines.

Closes angular#6247
Closes angular#6231
khepin pushed a commit to khepin/angular.js that referenced this pull request Feb 19, 2014
textInput shouldn't be applied to file inputs to ease writing of custom file input directives.

This change prevents file inputs from instantiating the text input parser/formatter pipelines.

Closes angular#6247
Closes angular#6231
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input[type="file"] defaults to textInput directive; conflicts w/ custom directive
3 participants