Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update to [email protected] and unpin the rxjs peerDeps via ^5.0.1 #13572

Closed
wants to merge 2 commits into from
Closed

feat: update to [email protected] and unpin the rxjs peerDeps via ^5.0.1 #13572

wants to merge 2 commits into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Dec 19, 2016

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@vicb vicb added action: review The PR is still awaiting reviews from at least one requested reviewer pr_state: LGTM and removed cla: no labels Dec 19, 2016
@crisbeto @vicb
feat: update to [email protected] and unpin the rxjs peerDeps via ^5.0.1
e93d126 
Now that rxjs is stable and the rxjs team follows semver, we can update and unpin the dependency safely.

From now on the Angular application/library developers are in charge of controlling the rxjs version as long as it's newer than 5.0.1.

closes angular#13561
closes angular#13478
closes angular#13572
@chuckjaz chuckjaz added cla: yes action: merge The PR is ready for merge by the caretaker and removed cla: no action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 19, 2016
@chuckjaz
Copy link
Contributor

Merged

@chuckjaz chuckjaz closed this Dec 20, 2016
chuckjaz pushed a commit that referenced this pull request Dec 20, 2016
@crisbeto @chuckjaz
feat: update to [email protected] and unpin the rxjs peerDeps via ^5.0.1 (#1…
171a9bd 
…3572)

Now that rxjs is stable and the rxjs team follows semver, we can update and unpin the dependency safely.

From now on the Angular application/library developers are in charge of controlling the rxjs version as long as it's newer than 5.0.1.

closes #13561
closes #13478
closes #13572
chuckjaz pushed a commit that referenced this pull request Dec 20, 2016
@crisbeto @chuckjaz
feat: update to [email protected] and unpin the rxjs peerDeps via ^5.0.1 (#1…
8d5da1e 
…3572)

Now that rxjs is stable and the rxjs team follows semver, we can update and unpin the dependency safely.

From now on the Angular application/library developers are in charge of controlling the rxjs version as long as it's newer than 5.0.1.

closes #13561
closes #13478
closes #13572
@vicb vicb deleted the gh-13561 branch January 17, 2017 17:50
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vicb @googlebot @chuckjaz @IgorMinar @crisbeto