fix(core): fix isComponentView() and isEmbeddedView() tests
#14789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
added
area: core
tbosch
reviewed
Feb 28, 2017
| @@ -141,11 +141,11 @@ export function elementEventFullName(target: string, name: string): string { | |||
| } | |||
|
|
|||
| export function isComponentView(view: ViewData): boolean { | |||
| return view.component === view.context && !!view.parent; | |||
| return !!view.parent && ((view.parentNodeDef.flags & NodeFlags.Component) != 0); | |||
There was a problem hiding this comment.
Maybe better: !!view.parent && !!(view.parentNodeDef.flags & NodeFlags.Component), same below. At least use !==0 (2 =, not just 1).
tbosch
approved these changes
Feb 28, 2017
vicb
added
action: merge
tbosch
approved these changes
Feb 28, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14778