Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform-server): setup NoopAnimationsModule in ServerModule by d… #15131

Closed
wants to merge 1 commit into from
Closed

fix(platform-server): setup NoopAnimationsModule in ServerModule by d… #15131

wants to merge 1 commit into from

Conversation

vikerman
Copy link
Contributor

@vikerman vikerman commented Mar 14, 2017

…efault

This is so that server side rendering does not throw an exception when it encounters animations on the server side and does not need the user to explicitly setup NoopAnimationsModule in their app server module.

Fixes #15098, #14784.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Server side rendering throws an exception even when using NoopAnimationsModule from app server module. The NoopAnimationsModule uses the DomRenderer by default and has to be routed through the ServerRenderer.

What is the new behavior?
NoopAnimationsModule is hooked up into ServerModule so that user does not have to do it themselves

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

@vikerman vikerman requested a review from alxhub March 14, 2017 14:29
@vikerman vikerman added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 14, 2017
@vikerman vikerman requested a review from IgorMinar March 17, 2017 16:30
…efault

This is so that server side rendering does not throw an exception when it encounters animations on the server side and does not need the user to explicitly setup NoopAnimationsModule in their app server module.

Fixes #15098, #14784.
@vikerman vikerman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 17, 2017
@vikerman vikerman changed the title WIP : fix(platform-server): setup NoopAnimationsModule in ServerModule by d… fix(platform-server): setup NoopAnimationsModule in ServerModule by d… Mar 17, 2017
@mhevery mhevery closed this in 5c5c2ae Mar 17, 2017
SamVerschueren pushed a commit to SamVerschueren/angular that referenced this pull request Mar 18, 2017
…efault (angular#15131)

This is so that server side rendering does not throw an exception when it encounters animations on the server side and does not need the user to explicitly setup NoopAnimationsModule in their app server module.

Fixes angular#15098, angular#14784.

PR Close angular#15131
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
…efault (angular#15131)

This is so that server side rendering does not throw an exception when it encounters animations on the server side and does not need the user to explicitly setup NoopAnimationsModule in their app server module.

Fixes angular#15098, angular#14784.

PR Close angular#15131
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
…efault (angular#15131)

This is so that server side rendering does not throw an exception when it encounters animations on the server side and does not need the user to explicitly setup NoopAnimationsModule in their app server module.

Fixes angular#15098, angular#14784.

PR Close angular#15131
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animations causing problems with SSR: document is not defined
5 participants