Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf compiler typecheck #19152

Closed
wants to merge 1 commit into from
Closed

Perf compiler typecheck #19152

wants to merge 1 commit into from

Conversation

tbosch
Copy link
Contributor

@tbosch tbosch commented Sep 11, 2017

No description provided.

@mary-poppins
Copy link

You can preview 6e7275b at https://pr19152-6e7275b.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 4c37f77 at https://pr19152-4c37f77.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 052b1e7 at https://pr19152-052b1e7.ngbuilds.io/.

@@ -21,6 +21,14 @@ export interface Diagnostic {
source: 'angular';
}

export function isTsDiagnostic(diagnostic: any): diagnostic is ts.Diagnostic {
return diagnostic && diagnostic.source != 'angular';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should return a boolean (same below)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also use !== for consistency while you're at it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mary-poppins
Copy link

You can preview 84c69ce at https://pr19152-84c69ce.ngbuilds.io/.

private actions: Expression[] = [];

constructor(
private _options: AotCompilerOptions, private reflector: StaticReflector,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why _ only for one field ? remove ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed all _ in this file...

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the minor comments

@mary-poppins
Copy link

You can preview 3c8290b at https://pr19152-3c8290b.ngbuilds.io/.

@tbosch tbosch force-pushed the perf_typecheck branch 2 times, most recently from 136ee51 to e6387aa Compare September 12, 2017 17:43
@mary-poppins
Copy link

You can preview 136ee51 at https://pr19152-136ee51.ngbuilds.io/.

@mary-poppins
Copy link

You can preview e6387aa at https://pr19152-e6387aa.ngbuilds.io/.

@mary-poppins
Copy link

You can preview f2e64c0 at https://pr19152-f2e64c0.ngbuilds.io/.

@tbosch tbosch added area: core Issues related to the framework runtime action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Sep 12, 2017
@mary-poppins
Copy link

You can preview da29984 at https://pr19152-da29984.ngbuilds.io/.

…ing.

This speeds up the compilation process significantly.

Also introduces a new option `fullTemplateTypeCheck` to do more checks in templates:
- check expressions inside of templatized content (e.g. inside of `<div *ngIf>`).
- check the arguments of calls to the `transform` function of pipes
- check references to directives that were exposed as variables via `exportAs`
@mary-poppins
Copy link

You can preview 6cfdd35 at https://pr19152-6cfdd35.ngbuilds.io/.

@matsko matsko closed this in 996c7c2 Sep 14, 2017
@tbosch tbosch deleted the perf_typecheck branch October 3, 2017 17:46
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants