fix(compiler): correctly map error message locations #19424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckjaz
force-pushed
the
fix-error-locations
branch
from
9f0dc83
to
3864833
Compare
|
You can preview 9f0dc83 at https://pr19424-9f0dc83.ngbuilds.io/. |
|
You can preview 3864833 at https://pr19424-3864833.ngbuilds.io/. |
vicb
approved these changes
Sep 28, 2017
vicb
added
action: merge
vicb
pushed a commit
that referenced
this pull request
Sep 28, 2017
JoostK
reviewed
Sep 28, 2017
| @@ -161,7 +161,7 @@ export class EmitterVisitorContext { | |||
| spanOf(line: number, column: number): ParseSourceSpan|null { | |||
| const emittedLine = this._lines[line - this._preambleLineCount]; | |||
| if (emittedLine) { | |||
| let columnsLeft = column - emittedLine.indent; | |||
| let columnsLeft = column - _createIndent(emittedLine.indent).length; | |||
There was a problem hiding this comment.
Couldn't we just use emittedLine.indent * _INDENT_WITH.length, same as is done at L124? That would avoid building the indentation string.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When mapping diagnostics errors from the generated source for a template the mapping would sometimes produce the wrong source span.
What is the new behavior?
The mapping of diagnostic error messages produce the correct source span.
Does this PR introduce a breaking change?