Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider wrong coloring [RTL] #2022

Closed
theunreal opened this issue Nov 29, 2016 · 5 comments
Closed

Slider wrong coloring [RTL] #2022

theunreal opened this issue Nov 29, 2016 · 5 comments
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@theunreal
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Spinner fill color correctly

What is the current behavior?

Spinner empty - Correct:
image
Spinner full - Correct:
image
Spinner with some value - incorrect
image
image

What are the steps to reproduce?

Put a spinner in html dir="rtl" angular 2 app

What is the use-case or motivation for changing an existing behavior?

Fixing RTL issue using the spinner module

Which versions of Angular, Material, OS, browsers are affected?

Angular 2.1.2
Material 10
Chrome, Edge

@JanStureNielsen
Copy link
Contributor

JanStureNielsen commented Nov 29, 2016

@theunreal - with RTL are the empty and full behaviors also incorrect? It seems like the empty spinner should be at the right-most position and the full spinner at the left-most position...

@crisbeto
Copy link
Member

I couldn't reproduce this locally, although the dragging gesture doesn't account for RTL. That's pending an RTL service, though.

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Nov 30, 2016
@jelbourn jelbourn changed the title Spinner wrong coloring [RTL] Slider wrong coloring [RTL] Nov 30, 2016
@jelbourn
Copy link
Member

@mmalerba does your latest PR fix this?

@mmalerba
Copy link
Contributor

yes, I believe #1794 will fix this

@mmalerba mmalerba closed this as completed Dec 2, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

5 participants