Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple speed too fast, and a bit too faded #2626

Closed
mxchange opened this issue Jan 13, 2017 · 3 comments
Closed

Ripple speed too fast, and a bit too faded #2626

mxchange opened this issue Jan 13, 2017 · 3 comments
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@mxchange
Copy link

Bug, feature request, or proposal:

The ripple speed on buttons (and all other ripple elements) is so fast it's barely noticeable, expecially on smaller and/or colored elements.
If I compare it to an android ripple effect, which seems about twice as slow.
material-ripple

What is the expected behavior?

The ripple effect to be slow enough to be noticeable, like on the latest Android versions.
And for the ripple color to be a bit more opaque, so it shows better on colored elements.

What is the current behavior?

The effect is only really noticeable on larger buttons.
And is not very noticeable on FABs, perhaps also more due to the ripple color being a bit too faded.

What are the steps to reproduce?

Run the demo-app

What is the use-case or motivation for changing an existing behavior?

I think it is not close enough to the material design specs/guidelines. Probably a 100ms would make a big difference already, or maybe 60/70ms, which in my experience tends to be high enough to notice.
Maybe it is a rendering issue with browsers (at the start of drawing), and with slower devices will seem too slow, while on fast devices it will look too fast, like in my case.

Which versions of Angular, Material, OS, browsers are affected?

Latest Chrome and Firefox

Is there anything else we should know?

I love you

@jelbourn
Copy link
Member

@EladBezalel the ripples should match MDC Web: https://material-components-web.appspot.com/button.html, which is the definitive correct ripple.

Want to take a look at this?

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Jan 27, 2017
@devversion
Copy link
Member

@mxchange This issue has been fixed as part of PR #2859. Thanks again for the issue.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

4 participants