Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogs are incorrect according to Material Design guidelines #3816

Closed
Ploppy3 opened this issue Mar 28, 2017 · 3 comments
Closed

Dialogs are incorrect according to Material Design guidelines #3816

Ploppy3 opened this issue Mar 28, 2017 · 3 comments

Comments

@Ploppy3
Copy link

Ploppy3 commented Mar 28, 2017

Bug:

How it should be:
image

How it is:
image

A working example I coded (20 lines of css - no content scroll support):
image
Source:
https://codepen.io/anon/pen/JWmXeQ

NB: Please note how everything in my demo is modular. The Title is optional, the Action div is optional. Adding more buttons or having only one does not break the CSS.


Here is a quick list of the errors for the dialog components:

  • Color for Title, should be rgba(0,0,0,87)
  • Color for Content, should be rgba(0,0,0,54)
  • Wrong padding for buttons, padding should be 8px around & in-between every buttons

Many of your components do not respect the material guidelines. If they are not fixed before official release you'll probably run into breaking changes.
https://material.io/guidelines/components/dialogs.html

@crisbeto
Copy link
Member

Yes, this is a known issue. I've been putting off fixing it since the scrolling behavior in general needs to be reworked first. I'll close this as a dupe, but you can keep an eye on #3239 and #2735.

@Ploppy3
Copy link
Author

Ploppy3 commented Mar 28, 2017

@crisbeto I hope the new version of the dialog will be as modular as possible. Unlike the current Toolbar as example. I don't think we are supposed to tweak the CSS when we want stock Material Design. I also hope you've read my warning at the end of this issue.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants