Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSR build: check null _document.defaultView #1337

Merged
merged 1 commit into from
Apr 4, 2021
Merged

Fix SSR build: check null _document.defaultView #1337

merged 1 commit into from
Apr 4, 2021

Conversation

dodongphure
Copy link
Contributor

@dodongphure dodongphure commented Apr 4, 2021 •
edited
Loading

Fixes #1324

@google-cla google-cla bot added the cla: yes label Apr 4, 2021
@dodongphure dodongphure mentioned this pull request Apr 4, 2021
Closed
@CaerusKaru CaerusKaru added pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for the caretaker to presubmit and merge pr: merge safe The caretaker can merge this PR without doing a presubmit labels Apr 4, 2021
@CaerusKaru CaerusKaru merged commit b43681c into angular:master Apr 4, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CaerusKaru CaerusKaru CaerusKaru approved these changes

Assignees
No one assigned
Labels
cla: yes pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for the caretaker to presubmit and merge pr: merge safe The caretaker can merge this PR without doing a presubmit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug SSR: Cannot read property 'removeEventListener' of null
2 participants
@dodongphure @CaerusKaru