Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(media-query): fix #187, fixed for platform-server/universal #346

Closed
wants to merge 2 commits into from
Closed

Conversation

ardatan
Copy link

@ardatan ardatan commented Jul 23, 2017

Now it gets document object from platform-browser by DI instead of global.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Jul 23, 2017
@ardatan
Copy link
Author

ardatan commented Jul 23, 2017

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Jul 23, 2017
@antonioparraga
Copy link

Please approve this guy!!!!!

@ThomasBurleson
Copy link
Contributor

@aparraga - testing is in-progress.

ThomasBurleson added a commit that referenced this pull request Jul 29, 2017
Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187. Closes #346.
@ThomasBurleson
Copy link
Contributor

Closing. See PR #353

ThomasBurleson added a commit that referenced this pull request Jul 29, 2017
Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187. Closes #346.
ThomasBurleson added a commit that referenced this pull request Jul 29, 2017
Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187. Closes #346.
ThomasBurleson added a commit that referenced this pull request Jul 30, 2017
Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187. Closes #346.
ThomasBurleson added a commit that referenced this pull request Jul 30, 2017
Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187. Closes #346.
ThomasBurleson added a commit that referenced this pull request Jul 30, 2017
Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187. Closes #346.
ThomasBurleson added a commit that referenced this pull request Jul 30, 2017
Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187. Closes #346.
ThomasBurleson added a commit that referenced this pull request Jul 30, 2017
Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187. Closes #346.
@antonioparraga
Copy link

When do you expect to release this guy?

@ThomasBurleson
Copy link
Contributor

Beta.9 should be released within the next 10 days... Dependent on 1-3 critical bug fixes remaining.

ThomasBurleson added a commit that referenced this pull request Aug 2, 2017
Use getDom() for platform-server/universal fixes
Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187, #354. Closes #346.
ThomasBurleson added a commit that referenced this pull request Aug 2, 2017
Use getDom() for platform-server/universal fixes
Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187, #354. Closes #346.
ThomasBurleson added a commit that referenced this pull request Aug 3, 2017
Use getDom() for platform-server/universal fixes
Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187, #354. Closes #346.
ThomasBurleson added a commit that referenced this pull request Aug 4, 2017
Use getDom() for platform-server/universal fixes
Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187, #354. Closes #346.
tinayuangao pushed a commit that referenced this pull request Aug 4, 2017
Use getDom() for platform-server/universal fixes
Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187, #354. Closes #346.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants