Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fxLayoutGap): update fxLayoutGap when only 1 child is remaining #444

Closed
wants to merge 3 commits into from
Closed

fix(fxLayoutGap): update fxLayoutGap when only 1 child is remaining #444

wants to merge 3 commits into from

Conversation

aldo-roman
Copy link
Contributor

fixes #433

@aldo-roman
Copy link
Contributor Author

@ThomasBurleson any comment on this PR? Thanks!

@ThomasBurleson
Copy link
Contributor

@aldo-roman - This is a good fix. Can you provide one unit test to verify the fix in this PR ?

@aldo-roman
Copy link
Contributor Author

Hi @ThomasBurleson ! Done! Sorry for not including them in the first place.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes in-progress pr: needs cleanup/tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fxLayoutGap not being updated after removing element from DOM
3 participants
@aldo-roman @ThomasBurleson @googlebot