-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(universal): correct fxLayout rendering, update LICENSE #466
Conversation
@CaerusKaru - has this PR been rebased with latest in |
@ThomasBurleson it’s all synced up |
@CaerusKaru - Ok, I will review. Thank you for this PR. |
- Remove default value of fxLayout to avoid confusion in Universal - Removed browser checks from style-utils since getDOM will always return an implementation with the methods implemented - Added note about getComputedStyle PR pending - Updated RxJS to 5.5.0 and added necessary fixes - Added better null and type checking throughout - Updated LICENSE
@CaerusKaru - why did you use a |
@ThomasBurleson Enter |
This is not a dealbreaker for me, and I'd be happy to change it back since it doesn't appear to affect functionality. I just thought it was an improved alternative. |
@CaerusKaru - Thank you for this PR. Merged in SHA 8dcae02 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
return an implementation with the methods implemented
updated other deps