Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Angular 6.1.x #799

Closed
MarcusMorba opened this issue Jul 13, 2018 · 13 comments
Closed

Support for Angular 6.1.x #799

MarcusMorba opened this issue Jul 13, 2018 · 13 comments
Assignees
Labels
build P1 Urgent issue that should be resolved before the next re-lease related: angular-core

Comments

@MarcusMorba
Copy link

MarcusMorba commented Jul 13, 2018

Feature Request

Support for Angular 6.1.x in general and the latest 6.1.0-rc.0.

What is the desired behavior?

Flex-Layout works with Angular 6.1.x

What is the use-case or motivation for the desired behavior?

Have a more stable base Angular Environment with 6.1.x for Upgrading a 5.x app.

Is there anything else we should know?

Would the latest 6.0.x beta work with Angular 6.1.x beta?

Current given dependencies of the latest 6 beta are:
"dependencies": {
"@angular/cdk": "6.0.0",
"@angular/common": "^6.0.0",
"@angular/compiler": "^6.0.0",
"@angular/core": "^6.0.0",
"@angular/platform-browser": "^6.0.0",
"core-js": "^2.4.1",
"rxjs": "^6.0.0",
"systemjs": "0.19.43",
"tsickle": "^0.27.0",
"tslib": "^1.8.0",
"zone.js": "^0.8.18"
},

@MarcusMorba
Copy link
Author

Thanks in advance for the feedback!

@MarcusMorba
Copy link
Author

MarcusMorba commented Jul 13, 2018

Should work, made a test on stackblitz.io: https://stackblitz.com/edit/angular-flex-layout-seed-kxsq7d
image

@MarcusMorba
Copy link
Author

Tested also successfull with the rc.0 versions.

@ThomasBurleson ThomasBurleson self-assigned this Jul 13, 2018
@ThomasBurleson ThomasBurleson added this to the v6.0.0-beta.17 milestone Jul 13, 2018
@CaerusKaru CaerusKaru added build related: angular-core P1 Urgent issue that should be resolved before the next re-lease labels Jul 14, 2018
@CaerusKaru
Copy link
Member

So there a few blockers on this, one of which I'm working to resolve, but the main one is that the CDK and Material don't support Angular v6.1 yet, and likely won't until the next RC at the earliest. Until that happens, we can't move since we have a peer dependency on them.

@mackelito
Copy link

@CaerusKaru I thought that one of the ideas was to have this lib as a standalone thing? If it has a dep on Materials then why keep it as a separate project? Perhpas you guys would benefit from working closer together? :)

Any how.. keep up the good work!

@CaerusKaru
Copy link
Member

@mackelito The library is mostly standalone, but part of the point is to not reuse code as much as possible, and the Angular CDK already implemented some of the library's codebase. It's more of the dependency on the CDK, we don't really have a dependency on Material (except for our own demo app).

There might be some closer collaboration in the future at least in regards to build and release schedules, but nothing is certain for now.

@fxck
Copy link

fxck commented Jul 26, 2018

Any progress on this since 6.4.1 is out?

@CaerusKaru
Copy link
Member

@fxck It’s blocked on angular/components#12182

@CaerusKaru
Copy link
Member

I’d like to be clear that the library has support for all 6.x versions of Angular, and I’m treating this issue more as the TS 2.9 migration than anything else. Material does not yet support TS 2.9 even though Angular Core does, so we’re waiting until Material jumps before we jump.

@probert94
Copy link

angular/material2#12182 has been merged and will hopefully land in a version soon.

@MarcusMorba
Copy link
Author

Isn´t this already achieved? In the latest beta18 "^6.1.6"is even required:
"version": "6.0.0-beta.18",
"requiredAngularVersion": ">=6.0.0 <7.0.0",
"dependencies": {
"@angular/cdk": "^6.4.7",
"@angular/common": "^6.1.6",
"@angular/compiler": "^6.1.6",
"@angular/core": "^6.1.6",
"@angular/platform-browser": "^6.1.6",
"core-js": "^2.5.7",
"rxjs": "^6.3.0",
"systemjs": "0.19.43",
"tsickle": "^0.32.1",
"tslib": "^1.9.3",
"zone.js": "^0.8.26"
},

@CaerusKaru
Copy link
Member

To be honest, I forgot about this issue entirely, but yes it has been resolved with the release of beta 18

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build P1 Urgent issue that should be resolved before the next re-lease related: angular-core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants