Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Breakpoints Documentation Examples #821

Open
MarcusMorba opened this issue Aug 24, 2018 · 4 comments
Open

Custom Breakpoints Documentation Examples #821

MarcusMorba opened this issue Aug 24, 2018 · 4 comments
Assignees
Labels
custom breakpoints Issues with Custom Breakpoint configuration and use docs P2 Issue that is important to resolve as soon as possible
Milestone

Comments

@MarcusMorba
Copy link

Proposal

Example use cases for improvements of the custom breakpoints documentation.

What is the summary of the proposal?

Improve the custom breakpoints documentation.

What is the proposal?

First the related flex-layout-version should be named somewhere for all or the related examples to ensure with which version it´s working.

I would like to see the following example use cases:

  1. Overwrite the default breakpoints with custom values
  2. Extend the xl-breakpoint with "gt-xl"-directive
  3. Add additional custom breakpoint "xxl" (incl. lt-xxl & gt-xxl) additional to existing breakpoints

Is there anything else we should know?

@MarcusMorba
Copy link
Author

An additional question: when using Configuration (https://github.com/angular/flex-layout/blob/master/guides/Configuration.md), is it still necessary to enable these custom, responsive selectors and to extend the ShowHideDirective and the LayoutDirective like explained (https://github.com/angular/flex-layout/wiki/Breakpoints).

To be able to "just" overwrite the default breakpoints and add additional custom breakpoints and done would be amazing.

@MarcusMorba
Copy link
Author

Here an example for a current project I have difficulties getting it work:
`const EPO_BREAKPOINTS = [
{ alias: 'xs', suffix: 'Xs', mediaQuery: 'screen and (max-width: 1024px)', overlapping: false },
{ alias: 'sm', suffix: 'Sm', mediaQuery: 'screen and (min-width: 1025px) and (max-width: 1280px)', overlapping: false },
{ alias: 'md', suffix: 'Md', mediaQuery: 'screen and (min-width: 1281px) and (max-width: 1599px)', overlapping: false },
{ alias: 'lg', suffix: 'Lg', mediaQuery: 'screen and (min-width: 1600px) and (max-width: 1919px)', overlapping: false },
{ alias: 'xl', suffix: 'Xl', mediaQuery: 'screen and (min-width: 1920px) and (max-width: 2250px)', overlapping: false },
{ alias: 'xxl', suffix: 'Xxl', mediaQuery: 'screen and (min-width: 2251px) and (max-width: 4096px)', overlapping: false },
{ alias: 'lt-sm', suffix: 'LtSm', mediaQuery: 'screen and (max-width: 1024px)', overlapping: false },
{ alias: 'lt-md', suffix: 'LtMd', mediaQuery: 'screen and (max-width: 1280px)', overlapping: false },
{ alias: 'lt-lg', suffix: 'LtLg', mediaQuery: 'screen and (max-width: 1599px)', overlapping: false },
{ alias: 'lt-xl', suffix: 'LtXl', mediaQuery: 'screen and (max-width: 1919px)', overlapping: false },
{ alias: 'lt-xxl', suffix: 'LtXxl', mediaQuery: 'screen and (max-width: 2250px)', overlapping: false },
{ alias: 'gt-xs', suffix: 'GtXs', mediaQuery: 'screen and (min-width: 1025px)', overlapping: false },
{ alias: 'gt-sm', suffix: 'GtSm', mediaQuery: 'screen and (min-width: 1281px)', overlapping: false },
{ alias: 'gt-md', suffix: 'GtMd', mediaQuery: 'screen and (min-width: 1600px)', overlapping: false },
{ alias: 'gt-lg', suffix: 'GtLg', mediaQuery: 'screen and (min-width: 1920px)', overlapping: false },
{ alias: 'gt-xl', suffix: 'GtXl', mediaQuery: 'screen and (min-width: 2251px)', overlapping: false }
];

export const CUSTOM_BREAKPOINTS = {
provide: BREAKPOINT,
useValue: EPO_BREAKPOINTS,
multi: true
};`

@CaerusKaru CaerusKaru self-assigned this Sep 12, 2018
@CaerusKaru CaerusKaru added docs P2 Issue that is important to resolve as soon as possible labels Sep 12, 2018
@CaerusKaru CaerusKaru added this to the v6.0.0-beta.19 milestone Sep 12, 2018
@MarcusMorba
Copy link
Author

@CaerusKaru : if you can provide some working app code examples I think I would be able to write some documentation.

@CaerusKaru CaerusKaru modified the milestones: 7.0.0-beta.20, Backlog Nov 13, 2018
@CaerusKaru CaerusKaru added custom breakpoints Issues with Custom Breakpoint configuration and use P0 Critical issue that needs to be resolved immediately and removed P2 Issue that is important to resolve as soon as possible labels Dec 2, 2018
@CaerusKaru
Copy link
Member

We'll be getting this in just as soon as #900 lands.

@CaerusKaru CaerusKaru modified the milestones: 11.0.0-beta.33, beta34 Nov 12, 2020
@CaerusKaru CaerusKaru added P2 Issue that is important to resolve as soon as possible and removed P0 Critical issue that needs to be resolved immediately labels Dec 23, 2021
@CaerusKaru CaerusKaru modified the milestones: 12.0.0-beta.34, Backlog Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
custom breakpoints Issues with Custom Breakpoint configuration and use docs P2 Issue that is important to resolve as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants