fix(fxLayoutAlign): add space-between and space-around options #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaerusKaru
requested changes
Sep 26, 2018
There was a problem hiding this comment.
I still have to review this with @ThomasBurleson tomorrow, until then please fix the style issues. Thanks for the PR!
| import { Platform } from '@angular/cdk/platform'; | ||
| import { CommonModule } from '@angular/common'; | ||
| import { Component, OnInit } from '@angular/core'; | ||
| import { ComponentFixture, inject, TestBed } from '@angular/core/testing'; |
There was a problem hiding this comment.
Please don't refactor our stylings
There was a problem hiding this comment.
Sorry, my VSCode refators stylings automatically.
Fixed and "git rebase master -i" and then "git push -f".
| import {extendObject} from '../../utils/object-extend'; | ||
| import {Layout, LayoutDirective} from '../layout/layout'; | ||
| import {LAYOUT_VALUES, isFlowHorizontal} from '../../utils/layout-validator'; | ||
| import { Directive, ElementRef, Input, OnChanges, OnDestroy, OnInit, Optional, Self, SimpleChanges } from '@angular/core'; |
…tions in the cross-axis The actual implementation doesn't allow the 'space-between' and 'space-around' flex align-content options in the cross-axis. fxLayoutAlign should cover all of them. This commit closes the issue angular#841
…tions in the cross-axis The actual implementation doesn't allow the 'space-between' and 'space-around' flex align-content options in the cross-axis. fxLayoutAlign should cover all of them. This commit closes the issue angular#841 angular#841
…tions in the cross-axis Styling refactor removed This commit closes the issue angular#841
aleixsuau
force-pushed
the
fix-issue-841
branch
from
7bef0fa
to
fe75421
Compare
CaerusKaru
approved these changes
Sep 27, 2018
CaerusKaru
added
pr: lgtm
|
Marking as blocked until I discuss with @ThomasBurleson, but otherwise looks good! |
CaerusKaru
changed the title
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual implementation doesn't allow the 'space-between' and 'space-around' flex
align-content options (cross-axis). fxLayoutAlign should cover all of them.
Closes #841