Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When element(by.css or element(by.id finds no element it aborts all tests #11

Open
richtera opened this issue Oct 8, 2014 · 1 comment

Comments

@richtera
Copy link

richtera commented Oct 8, 2014

I think the flowFinished should look like this:

        var flowFinished = flow.execute(function() {
          try {
            fn.call(jasmine.getEnv().currentSpec, function(userError) {
              if (userError) {
                asyncFnDone.reject(new Error(userError));
              } else {
                asyncFnDone.fulfill();
              }
            });
          }
          catch (ex) {
            asyncFnDone.reject(ex);
          }
        }, desc_);

So that it can reject exceptions thrown within the callback.
This will correctly mark the current spec as failed but will continue.

@richtera
Copy link
Author

richtera commented Oct 8, 2014

Added pull request #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant