Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jasminewd breaks toThrow and toThrowError matchers #33

Open
scriby opened this issue Oct 6, 2015 · 0 comments
Open

jasminewd breaks toThrow and toThrowError matchers #33

scriby opened this issue Oct 6, 2015 · 0 comments

Comments

@scriby
Copy link

scriby commented Oct 6, 2015

I suspect that you never really intended for these matchers to be used in an UI test, and in that sense my case is probably somewhat unique.

I was wondering if it might be possible/reasonable to not make expect async unless a promise is passed to it, otherwise just let it behave like a normal jasmine expect. I think this would allow toThrow and toThrowError to work and not adversely affect other use cases.

(As a little more background info, I am using fibers to "block" execution of the test and don't need to use jasminewd, but because it's included automatically by protractor I don't think it can be avoided. I had a situation arise where using .toThrow(Error) would be a nice solution but noticed that it doesn't work with jasminewd.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant