-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ngc): _onDragStart/End are called with one param #1113
Conversation
@@ -213,7 +213,7 @@ export class MdSlideToggle implements AfterContentInit, ControlValueAccessor { | |||
|
|||
|
|||
/** TODO: internal */ | |||
_onDragStart() { | |||
_onDragStart(event: Event) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why don't we remove the parameters from the HTML instead (This does not show any linter warnings / infos etc.)
- Or make it consistent with the
onDrag
function, by usingHammerInput
instead? (to get proper autocompletion)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, removed the parameter at the callsite instead.
On Wed, Aug 24, 2016 at 12:58 PM Paul Gschwendtner [email protected]
wrote:
In src/lib/slide-toggle/slide-toggle.ts
#1113 (comment):@@ -213,7 +213,7 @@ export class MdSlideToggle implements AfterContentInit, ControlValueAccessor {
/** TODO: internal */
- _onDragStart() {
- _onDragStart(event: Event) {
- Why don't we remove the parameters from the HTML instead (This does
not show any linter warnings / infos etc.)- Or make it consistent with the onDrag function, by using HammerInput
instead? (to get proper autocompletion)—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/angular/material2/pull/1113/files/1b317155f01c442ddea69907006dca011d73392c#r76127308,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC5IxzZ79qWPomEoy50jO6QDXmcEld0ks5qjKJagaJpZM4JsYxG
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :)
LGTM |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #1112