feat(dialog): add focus management #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
approved these changes
Sep 24, 2016
| // the dialog was opened. Wait for the DOM to finish settling before changing the focus so | ||
| // that it doesn't end up back on the <body>. | ||
| this._ngZone.onMicrotaskEmpty.first().subscribe(() => { | ||
| (this._elementFocusedBeforeDialogWasOpened as HTMLElement).focus(); |
There was a problem hiding this comment.
Do you prefer as HTMLElement to (<HTMLElement>this.whatever).focus() ?
There was a problem hiding this comment.
I didn't know the as syntax existed until recently; I do this it is a bit cleaner and more in keeping with TypeScript's normally putting the type at the end. We can chat about it when we're all back in the office.
There was a problem hiding this comment.
Don't feel strongly about it; was just curious
| let attachResult = this._portalHost.attachComponentPortal(portal); | ||
|
|
||
| // If were to attempt to focus immediately, then the content of the dialog would not yet be | ||
| // ready in stances where change detection has to run first. To deal with this, we simply |
| flushMicrotasks(); | ||
|
|
||
| expect(document.activeElement.tagName) | ||
| .toBe('INPUT', 'Expected the first tabbale element (input) in the dialog to be focused.'); |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @kara or @hansl
This is the final PR necessary before publishing dialog.
(though there's still plenty to do after that)