Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(overlay): add custom classes for backdrop #1532

Merged
merged 1 commit into from
Oct 19, 2016
Merged

Conversation

kara
Copy link
Contributor

@kara kara commented Oct 19, 2016

This PR allows components to add a custom class to the overlay backdrop. This will allow us to use the backdrop as a click catcher in components like the menu and the select.

r: @jelbourn

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 19, 2016
@fxck
Copy link
Contributor

fxck commented Oct 19, 2016

#1438

@kara
Copy link
Contributor Author

kara commented Oct 19, 2016

@fxck Can you elaborate? Your PR appears to have to do with overlay panes, not overlay backdrops. I assume @jelbourn will want to weigh in on the design for that one separately.

@fxck
Copy link
Contributor

fxck commented Oct 19, 2016

Hm, thought the backdrop was a child of the pane and thus the custom class on it could be used, but it's a child of the overlay.. so yeah. Ignore my comment.

@jelbourn
Copy link
Member

LGTM

@kara kara added the action: merge The PR is ready for merge by the caretaker label Oct 19, 2016
@jelbourn jelbourn merged commit 0b54668 into angular:master Oct 19, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants