Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(radio): Add ripple effect to radio button #1553

Merged
merged 1 commit into from
Oct 27, 2016
Merged

feature(radio): Add ripple effect to radio button #1553

merged 1 commit into from
Oct 27, 2016

Conversation

tinayuangao
Copy link
Contributor

@tinayuangao tinayuangao commented Oct 20, 2016 •
edited
Loading

Removed the ripple placeholder and added the real md-ripple

Closes issue #1449
R: jelbourn

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Oct 20, 2016
@tinayuangao tinayuangao added pr: needs review and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Oct 20, 2016
@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Oct 24, 2016
@jelbourn jelbourn added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Oct 25, 2016
@jelbourn
Copy link
Member

CC @dozingcat if you happen to have a bit of time, could you also take a look?

jelbourn
jelbourn reviewed Oct 26, 2016
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally made this comment a few days ago and then forgot to send it.

src/lib/radio/radio.ts
return this._elementRef.nativeElement;
}

isRippleEnabled() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this method instead of binding directly to the disableRipple property?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can bind directly to the disableRipple property. Just referred what button did for ripple. I can change that for button too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced and resolved conflicts. Use coerceBooleanProperty for disableRipple.

@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Oct 26, 2016
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Oct 26, 2016
@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn merged commit d83b3e0 into angular:master Oct 27, 2016
@tinayuangao tinayuangao mentioned this pull request Nov 1, 2016
Closed
@tinayuangao tinayuangao deleted the ripple branch November 2, 2016 17:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn left review comments

Assignees

@jelbourn jelbourn

Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tinayuangao @jelbourn @googlebot