Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing space on MdCheckbox scrolls the page #162

Closed
hansl opened this issue Mar 15, 2016 · 2 comments
Closed

Pressing space on MdCheckbox scrolls the page #162

hansl opened this issue Mar 15, 2016 · 2 comments
Assignees
@traviskaufman
Labels
Accessibility This issue is related to accessibility (a11y) P2 The issue is important to a large percentage of users, with a workaround
Milestone
alpha.2

Comments

@hansl
Copy link
Contributor

hansl commented Mar 15, 2016

We need to prevent the event from bubbling in this case.
@hansl hansl added P2 The issue is important to a large percentage of users, with a workaround Accessibility This issue is related to accessibility (a11y) effort1: easy (hours) labels Mar 15, 2016
@jelbourn jelbourn assigned traviskaufman and unassigned rfru Mar 15, 2016
@jelbourn jelbourn added this to the alpha.2 milestone Mar 15, 2016
traviskaufman added a commit to traviskaufman/material2 that referenced this issue Mar 16, 2016
@traviskaufman
fix(MdCheckbox): Cancel spacebar keydown events when component focused
1ed6aa9 
This commit ensures that when a checkbox element is focused, spacebar
`keydown` events will not bubble up to window, causing side effects like
page scrolling.

This commit also fixes an issue as part of this change where the
component could still be focused even when it was disabled.

Finally, some of the test code has been cleaned up and corrected.

Fixes angular#162
traviskaufman added a commit to traviskaufman/material2 that referenced this issue Mar 16, 2016
@traviskaufman
fix(MdCheckbox): Cancel spacebar keydown events when component focused
4d9c263 
This commit ensures that when a checkbox element is focused, spacebar
`keydown` events will not bubble up to window, causing side effects like
page scrolling.

This commit also fixes an issue as part of this change where the
component could still be focused even when it was disabled.

Finally, some of the test code has been cleaned up and corrected.

Fixes angular#162
@traviskaufman traviskaufman mentioned this issue Mar 16, 2016
Closed
@traviskaufman
Copy link
Contributor

@hansl @jelbourn PR ready for review

traviskaufman added a commit to traviskaufman/material2 that referenced this issue Mar 17, 2016
@traviskaufman
fix(checkbox): Cancel spacebar keydown events when component focused
fcee873 
This commit ensures that when a checkbox element is focused, spacebar
`keydown` events will not bubble up to window, causing side effects like
page scrolling.

This commit also fixes an issue as part of this change where the
component could still be focused even when it was disabled.

Finally, some of the test code has been cleaned up and corrected.

Fixes angular#162
traviskaufman added a commit to traviskaufman/material2 that referenced this issue Mar 17, 2016
@traviskaufman
fix(checkbox): Cancel spacebar keydown events when component focused
ac84e25 
This commit ensures that when a checkbox element is focused, spacebar
`keydown` events will not bubble up to window, causing side effects like
page scrolling.

This commit also fixes an issue as part of this change where the
component could still be focused even when it was disabled.

Finally, some of the test code has been cleaned up and corrected.

Fixes angular#162
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@traviskaufman traviskaufman

Labels
Accessibility This issue is related to accessibility (a11y) P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
alpha.2
Development

Successfully merging a pull request may close this issue.

fix(MdCheckbox): Cancel spacebar keydown events when component focused traviskaufman/material2
4 participants
@hansl @jelbourn @traviskaufman @rfru