fix(radio): only emit change event with user input #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
reviewed
Nov 1, 2016
| @@ -152,21 +152,22 @@ describe('MdRadio', () => { | |||
| expect(spies[1]).toHaveBeenCalledTimes(1); | |||
| }); | |||
|
|
|||
| it('should emit a change event from the radio group', () => { | |||
| it('should not emit a change event from the radio group when change group value ' | |||
| + 'programmatically', () => { | |||
There was a problem hiding this comment.
Have you considered using backticks instead? That way you don't need the +
| @@ -242,34 +243,36 @@ describe('MdRadio', () => { | |||
|
|
|||
| fixture.detectChanges(); | |||
|
|
|||
| expect(changeSpy).toHaveBeenCalled(); | |||
| expect(changeSpy).toHaveBeenCalledTimes(0); | |||
There was a problem hiding this comment.
I think you can do
expect(changeSpy).not.toHaveBeenCalled()
Might be more natural-sounding
| @@ -171,6 +166,13 @@ export class MdRadioGroup implements AfterContentInit, ControlValueAccessor { | |||
| } | |||
| } | |||
|
|
|||
| emitChangeEvent(): void { | |||
There was a problem hiding this comment.
Did you want this to be part of the public API? It seems to me like it should use the _ prefix convention so people know it's internal (only used by the button)
tinayuangao
force-pushed
the
radio-event
branch
from
813ad00
to
7c7cff7
Compare
|
Comment addressed. Please take another look. Thanks for review! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1523
R: @kara @jelbourn