fix(md-spinner): animation not being cleaned up when used with AoT #1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the `md-spinner` animation interval not being cleaned up when the app has been compiled through the AoT. This is due to the the fact that the `ngOnDestroy` handler is in the base `MdProgressCircle` class. Fixes angular#1283.
googlebot
added
the
cla: yes
jelbourn
reviewed
Nov 12, 2016
| // The `ngOnDestroy` from `MdProgressCircle` should be called explicitly, because | ||
| // in certain cases Angular won't call it (e.g. when using AoT and in unit tests). | ||
| super.ngOnDestroy(); | ||
| } |
There was a problem hiding this comment.
@tbosch Is this the intended behavior for generated code?
There was a problem hiding this comment.
Just to note that this happens in the unit tests as well. I'm pretty sure that they're not using AoT.
jelbourn
added
pr: lgtm
action: merge
|
LGTM |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 15, 2016
Similarly to angular#1838, the `tab-link` destroy handler may not be called in certain situations, because it is being inherited from the MdRipple class. This PR explicitly calls the destroy handler.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 17, 2016
* Similarly to angular#1838, the `tab-link` destroy handler may not be called in certain situations, because it is being inherited from the MdRipple class. This PR explicitly calls the destroy handler. * Adds a unit test to make sure that the ripples are being cleaned up properly.
tinayuangao
pushed a commit
that referenced
this pull request
Nov 28, 2016
* Similarly to #1838, the `tab-link` destroy handler may not be called in certain situations, because it is being inherited from the MdRipple class. This PR explicitly calls the destroy handler. * Adds a unit test to make sure that the ripples are being cleaned up properly.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
md-spinneranimation interval not being cleaned up when the app has been compiled through the AoT.This is due to the the fact that the
ngOnDestroyhandler is in the baseMdProgressCircleclass.Fixes #1283.
Note: At some point it may be better to reorganize the component so we have the following setup:
This should avoid having to refer to the
superclass for things like cleaning up the animation.