fix(dialog): avoid subpixel rendering issues and refactor GlobalPositionStrategy #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Dec 1, 2016
| z-index: $md-z-index-overlay-container; | ||
| } | ||
|
|
||
| // Wrapper element for the panes that use the GlobalPositionStrategy. |
There was a problem hiding this comment.
Expand this with something like
// We use an extra wrapper element in order to use make the overlay itself a flex item.
// This makes centering the overlay easy without running into the subpixel rendering
// problems tied to using `transform`.| private _rightOffset: string = ''; | ||
| private _alignItems: string = ''; | ||
| private _justifyContent: string = ''; | ||
| private _wrapper: HTMLElement; |
There was a problem hiding this comment.
Add description for _wrapper that explains what it's for and that it's lazily created.
| @@ -3,4 +3,7 @@ export interface PositionStrategy { | |||
|
|
|||
| /** Updates the position of the overlay element. */ | |||
| apply(element: Element): Promise<void>; | |||
|
|
|||
| /** Cleans up any DOM modifications made by the position strategy, if necessary. */ | |||
| dispose?(): void; | |||
There was a problem hiding this comment.
Let's make this required and give ConnectedPositionStrategy a no-op dispose, then we won't have to check whether it exists before calling it.
…ionStrategy Refactors the `GlobalPositionStrategy` to use flexbox for positioning. This avoids the subpixel rendering issues that come with using transforms for centering. Fixes angular#932.
crisbeto
force-pushed
the
global-position-flexbox-proper
branch
from
348cb42
to
eab458f
Compare
|
Applied the feedback and rebased. |
jelbourn
added
pr: lgtm
action: merge
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the
GlobalPositionStrategyto use flexbox for positioning. This avoids the subpixel rendering issues that come with using transforms for centering.Fixes #932.