Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: add align attribute to md-dialog-actions #2483

Closed
icepeng opened this issue Dec 31, 2016 · 2 comments · Fixed by #2557
Closed

Feature request: add align attribute to md-dialog-actions #2483

icepeng opened this issue Dec 31, 2016 · 2 comments · Fixed by #2557
Assignees
@crisbeto

Comments

@icepeng
Copy link

icepeng commented Dec 31, 2016

md-card-actions has 'align' attribute that allows us to sort elements. I thought md-dialog-actions has same attribute, but not. It is not necessary, but needs to be implemented for consistency.
@icepeng icepeng changed the title add align attribute to md-dialog-actions Feature request: add align attribute to md-dialog-actions Dec 31, 2016
@crisbeto
Copy link
Member

This was planned actually.

@crisbeto crisbeto self-assigned this Dec 31, 2016
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 6, 2017
@crisbeto
feat(dialog): add the ability to align the content of md-dialog-actions
db8dc5b 
Adds the `align` attribute, which can be set to `end` or `middle`, that allows users to align the content of the `md-dialog-actions`.

Fixes angular#2483.
@crisbeto crisbeto mentioned this issue Jan 6, 2017
Merged
@crisbeto crisbeto added the has pr label Jan 6, 2017
tinayuangao pushed a commit that referenced this issue Jan 13, 2017
@crisbeto @tinayuangao
feat(dialog): add the ability to align the content of md-dialog-actio…
e18ab5d 
…ns (#2557)

* feat(dialog): add the ability to align the content of md-dialog-actions

Adds the `align` attribute, which can be set to `end` or `middle`, that allows users to align the content of the `md-dialog-actions`.

Fixes #2483.

* Fix linter error.

* Rename "middle" to "center".
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(dialog): add the ability to align the content of md-dialog-actions crisbeto/material2
2 participants
@crisbeto @icepeng