feat(list-key-manager): active descendant support #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
approved these changes
Jan 12, 2017
| */ | ||
| export interface Highlightable extends CanDisable { | ||
| setActiveStyles(): void; | ||
| setInactiveStyles(): void; |
There was a problem hiding this comment.
How about activate() and deactivate()?
There was a problem hiding this comment.
For posterity: Discussed offline and we will leave
This was referenced Jan 13, 2017
kara
added a commit
to kara/material2
that referenced
this pull request
Jan 20, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds key management for lists where changing the focus is not desired. There are now two types of key managers: FocusKeyManager (which will set focus) and ActiveDescendantKeyManager (which will simply set active styles and manage a11y through activedescendant). The latter will be useful for an autocomplete so the text field can retain focus while iterating through the list.
r: @jelbourn