Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using md-select in components template breaks banana-binding #2609

Closed
AsherBarak opened this issue Jan 12, 2017 · 2 comments · Fixed by #2704
Closed

Using md-select in components template breaks banana-binding #2609

AsherBarak opened this issue Jan 12, 2017 · 2 comments · Fixed by #2704
Assignees

Comments

@AsherBarak
Copy link

AsherBarak commented Jan 12, 2017

this seems to be a Bug

Summary

When using md-select in the template of a component to be used with [(ngModule)] (implementing ControlValueAccessor), said component binding does not function (internally, angular does not invoke ControlValueAccessor methods)

What are the steps to reproduce?

http://plnkr.co/edit/BzgXV2?p=preview
This plunker contains two identical components where the only difference is the inclusion of md-select in the template of with-select component. This breaks banana binding as described.

Is there anything else we should know?

I have nested other banana-bound components into my components with no issue.

See also angular/angular#13886

@kara
Copy link
Contributor

kara commented Jan 17, 2017

@AsherBarak We forgot to include the @Self() decorator, so the select is overwriting your custom value accessor. Should be a quick fix. Looking into doing so now.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants