Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

md-menu open on the bad side #2658

Closed
Socolin opened this issue Jan 14, 2017 · 6 comments · Fixed by #2677
Closed

md-menu open on the bad side #2658

Socolin opened this issue Jan 14, 2017 · 6 comments · Fixed by #2677
Assignees
@crisbeto

Comments

@Socolin
Copy link

Socolin commented Jan 14, 2017

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Menu should open on the defined side

What is the current behavior?

See plunker

What are the steps to reproduce?

Click on button
Scroll down
Click again on button
http://plnkr.co/edit/jsQ5z1nu51iEqB0pk9kW?p=preview

Which versions of Angular, Material, OS, browsers are affected?

Material beta 2.0
Angular 2.3.1
@crisbeto
Copy link
Member

In this case the menu doesn't open on the proper side, because it would go outside of the viewport and the user wouldn't be able to see the content. This is the intended behaviour.

@Socolin
Copy link
Author

Socolin commented Jan 15, 2017

If it appear on the proper side in this case it would be visible, but it open on the bad side and the menu is not readable.

When it open with no scroll it open on good side and its visible
When it open with scroll it open on the other side and is hidden

@crisbeto
Copy link
Member

I'm not sure what you mean. It opens up properly for me:

jbiujrp

@Socolin
Copy link
Author

Socolin commented Jan 15, 2017

The bug is when open after scroll when the md-card is moved down with [style.top] to stay on screen

image

image

@crisbeto
Copy link
Member

Alright, I see it now. Sorry for closing it initially.

@crisbeto crisbeto reopened this Jan 15, 2017
@crisbeto crisbeto self-assigned this Jan 16, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 16, 2017
@crisbeto
fix(connected-position-strategy): wrong logic when determining whethe…
d4ba706 
…r element is on screen

Fixes some faulty logic, introduced in angular#2102, that meant that the overlay considers the viewport's scroll offset when determining how much it overflows on either side.

Fixes angular#2658.
@crisbeto crisbeto mentioned this issue Jan 16, 2017
Merged
mmalerba pushed a commit that referenced this issue Jan 18, 2017
@crisbeto @mmalerba
fix(connected-position-strategy): wrong logic when determining whethe…
e055d05 
…r element is on screen (#2677)

Fixes some faulty logic, introduced in #2102, that meant that the overlay considers the viewport's scroll offset when determining how much it overflows on either side.

Fixes #2658.
kara pushed a commit to kara/material2 that referenced this issue Jan 20, 2017
@crisbeto @kara
fix(connected-position-strategy): wrong logic when determining whethe…
127f4cf 
…r element is on screen (angular#2677)

Fixes some faulty logic, introduced in angular#2102, that meant that the overlay considers the viewport's scroll offset when determining how much it overflows on either side.

Fixes angular#2658.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Socolin @crisbeto