Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): support use inside a custom value accessor #2704

Merged
merged 1 commit into from
Jan 19, 2017

Conversation

kara
Copy link
Contributor

@kara kara commented Jan 17, 2017

Fixes #2609.

@kara kara requested a review from jelbourn January 17, 2017 23:30
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 17, 2017
@jelbourn
Copy link
Member

LGTM

Do other components need to do anything like this as well?

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 17, 2017
@kara
Copy link
Contributor Author

kara commented Jan 17, 2017

@jelbourn I believe this is the only component right now that sets the value accessor directly. mdInput uses the default value accessor for text fields and the others use the provider syntax (which will work correctly).

@mmalerba mmalerba merged commit 651440f into angular:master Jan 19, 2017
kara added a commit to kara/material2 that referenced this pull request Jan 20, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using md-select in components template breaks banana-binding
4 participants