Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): fix ink not showing on chrome 57 #3041

Merged
merged 3 commits into from
Feb 13, 2017

Conversation

andrewseguin
Copy link
Contributor

The ink bar was positioned absolutely in a display flex element, which no longer plays nice in Chome (beta, v 57). Moved the ink bar out of the display flex element. Also fixed issue for the nav bar, which did not always show the ink bar on first render.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 10, 2017

/** Checks if the active link has been changed and, if so, will update the ink bar. */
ngAfterContentChecked(): void {
if (this._activeLinkChanged) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we can't do this in the updateActiveLink method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial set for active is performed while the component is setting up and before the content is ready, so the ink bar doesn't know what to align to. Subsequent calls would be fine but we're seeing an issue with the first load of the component.

Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit f24832c into angular:master Feb 13, 2017
@andrewseguin andrewseguin deleted the missing-ink-on-tab-header branch February 23, 2017 20:58
@rupamroy
Copy link

rupamroy commented May 8, 2017

I am using "@angular/material": "^2.0.0-beta.3", which is the latest npm pulled .

My html looks like this

<md-toolbar>
  <h1>My test application</h1>
  <nav md-tab-nav-bar>
    <a md-tab-link [routerLink]="['']" routerLinkActive #rla="routerLinkActive" [active]="rla.isActive">Home</a>
  </nav>
</md-toolbar>

And here is how the tab is being rendered
screen shot 2017-05-08 at 11 24 30 am

Can you please tell me what am I doing wrong or this is still an issue that team is working on?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants