Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button): raised buttons in dark theme #3070

Merged
merged 1 commit into from
Feb 13, 2017
Merged

fix(button): raised buttons in dark theme #3070

merged 1 commit into from
Feb 13, 2017

Conversation

devversion
Copy link
Member

@devversion devversion commented Feb 12, 2017 •
edited
Loading

  • Fixes the wrong background and foreground color for raised buttons in a dark theme.

Also here is an comparison of an Android app using AppCompat (dark theme)

Before After Expected

The background and foreground hues are specified to be grey@800 here

@devversion
fix(button): raised buttons in dark theme
982eeb5 
* Fixes the wrong background and foreground color for raised buttons in a dark theme.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 12, 2017
tinayuangao
tinayuangao approved these changes Feb 13, 2017
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tinayuangao tinayuangao added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 13, 2017
@andrewseguin andrewseguin merged commit 87ab712 into angular:master Feb 13, 2017
@devversion devversion deleted the fix/button-raised-dark branch February 14, 2017 07:39
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tinayuangao tinayuangao tinayuangao approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @tinayuangao @googlebot @andrewseguin